fix(plugin): opencode run waits for plugins to finish before stopping process#23381
Open
0byte-coding wants to merge 6 commits intoanomalyco:devfrom
Open
fix(plugin): opencode run waits for plugins to finish before stopping process#233810byte-coding wants to merge 6 commits intoanomalyco:devfrom
0byte-coding wants to merge 6 commits intoanomalyco:devfrom
Conversation
|
looks good |
- Track pending plugin event handlers in plugin service - Add OPENCODE_EXPERIMENTAL_PLUGIN_EXIT_DEFAULT_TIMEOUT_MS env var (default: 60000ms) - Wait for pending plugin events when session becomes idle - Await event loop completion in run command before exiting Fixes issue where plugins were interrupted mid-execution when opencode-dev run exits, causing incomplete plugin processing.
Adds test to ensure plugins complete their event handlers before opencode exits. Test verifies: - Plugin event handlers complete within timeout - Timeout mechanism works correctly Test catches the regression by failing when the event tracking or waitForPendingEvents mechanism is disabled.
0byte-coding
force-pushed
the
fix/plugin-exit-wait
branch
from
5269472 to
a2fada5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23380
Type of change
What does this PR do?
How did you verify your code works?
Screenshots / recordings
N/A
Checklist